Skip to content

fix: align passive silkscreen geometry with KiCad standards#612

Open
techmannih wants to merge 4 commits intotscircuit:mainfrom
techmannih:jap
Open

fix: align passive silkscreen geometry with KiCad standards#612
techmannih wants to merge 4 commits intotscircuit:mainfrom
techmannih:jap

Conversation

@techmannih
Copy link
Copy Markdown
Member

@techmannih techmannih commented Apr 30, 2026

Silkscreen fixes mainly for passive footprints, but now silkscreen comparison is enabled and verified for all footprints in the parity test suite.

Precision Geometry: Replaced heuristic silkscreen sizing with exact KiCad-derived values for all standard passive sizes (0402 through 2512).

Visual Parity: Refactored silkscreen paths to use the KiCad-standard dual horizontal line style.

@techmannih techmannih requested a review from seveibar as a code owner April 30, 2026 03:51
@techmannih techmannih changed the title fix: align passive and resistor array silkscreen geometry with KiCad standards fix: align passive and array silkscreen geometry with KiCad standards Apr 30, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf2b232b93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/helpers/chipArray.ts
Comment thread src/helpers/passive-fn.ts Outdated
@techmannih techmannih changed the title fix: align passive and array silkscreen geometry with KiCad standards fix: align passive silkscreen geometry with KiCad standards Apr 30, 2026
Comment thread src/helpers/passive-fn.ts Outdated
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really bad change, all capacitors lose polarity, we're also not interested in copying kicad completely

@techmannih techmannih closed this Apr 30, 2026
@techmannih techmannih reopened this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants