fix: align passive silkscreen geometry with KiCad standards#612
Open
techmannih wants to merge 4 commits intotscircuit:mainfrom
Open
fix: align passive silkscreen geometry with KiCad standards#612techmannih wants to merge 4 commits intotscircuit:mainfrom
techmannih wants to merge 4 commits intotscircuit:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf2b232b93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seveibar
reviewed
Apr 30, 2026
seveibar
requested changes
Apr 30, 2026
Contributor
seveibar
left a comment
There was a problem hiding this comment.
really bad change, all capacitors lose polarity, we're also not interested in copying kicad completely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silkscreen fixes mainly for passive footprints, but now silkscreen comparison is enabled and verified for all footprints in the parity test suite.
Precision Geometry: Replaced heuristic silkscreen sizing with exact KiCad-derived values for all standard passive sizes (0402 through 2512).
Visual Parity: Refactored silkscreen paths to use the KiCad-standard dual horizontal line style.