Supported holes for stampreceiver and modified pad length and holes position of stampboard#71
Merged
AnasSarkiz merged 3 commits intotscircuit:mainfrom Oct 21, 2024
AnasSarkiz:main
Merged
Supported holes for stampreceiver and modified pad length and holes position of stampboard#71AnasSarkiz merged 3 commits intotscircuit:mainfrom AnasSarkiz:main
AnasSarkiz merged 3 commits intotscircuit:mainfrom
AnasSarkiz:main
Conversation
…osition of stampboard
seveibar
reviewed
Oct 21, 2024
| platedhole( | ||
| i + 1, | ||
| params.w / 2 - params.pl + outerDiameter / 2, | ||
| params.w / 2 - 1.61, |
Contributor
There was a problem hiding this comment.
Is this intentionally hard coded? Shouldnt it be derived or a default?
Member
Author
There was a problem hiding this comment.
I write it hard coded to be like the data sheet
if I need it to be dynamic then I need to modify `params.pl + outerDiameter / 2`
Contributor
There was a problem hiding this comment.
oh we just need to give a name to that distance and set the default to 1.61. That parameter should be called innerholeedgedistance i think
Contributor
|
We can keep it hard coded if we create a CONSTANT that explains what it is eg TOP_BOTTOM_RECESSION_OFFSET |
seveibar
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.