add custom unit conversion#3
Merged
seveibar merged 2 commits intotscircuit:mainfrom Aug 30, 2024
Merged
Conversation
Contributor
|
Can you use tscircuit/plop to add a biome.json and a workflow for checking formatting to this repo. I noticed the formatting was a bit different which will cause problems for other contributors and also makes the diff difficult to read |
Contributor
|
@abhijitxy oh also can you add a |
seveibar
requested changes
Aug 30, 2024
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
the code itself is awesome, but requesting changes while we setup the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2