Skip to content

fixed component-type missing props#160

Closed
Rishikesh63 wants to merge 5 commits intotscircuit:mainfrom
Rishikesh63:component-type
Closed

fixed component-type missing props#160
Rishikesh63 wants to merge 5 commits intotscircuit:mainfrom
Rishikesh63:component-type

Conversation

@Rishikesh63
Copy link

/claim #159

@Anshgrover23
Copy link
Contributor

@Rishikesh63 also checks failing.

@Rishikesh63
Copy link
Author

@Anshgrover23 Please review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why u have changed this file?? remove it

@Rishikesh63
Copy link
Author

@Anshgrover23 I removed changes in component-test

@Anshgrover23
Copy link
Contributor

@Rishikesh63 see message clearly i have i have said you why u have changed transistor test.

@Rishikesh63
Copy link
Author

@Rishikesh63 see message clearly i have i have said you why u have changed transistor test.

That time this test cause error during running command of test so I changed that

@Rishikesh63
Copy link
Author

@Anshgrover23 this was the error occurs when i was run - bun test
tests/transistor.test.ts:
687 | }
688 | parse(data, params) {
689 | const result = this.safeParse(data, params);
690 | if (result.success)
691 | return result.data;
692 | throw result.error;
^
ZodError: [
{
"expected": "'npn' | 'pnp' | 'bjt' | 'jfet' | 'mosfet'",
"received": "undefined",
"code": "invalid_type",
"path": [
"type"
],
"message": "Required"
}
]
at parse (/mnt/c/Users/User/Desktop/props/node_modules/zod/lib/index.mjs:692:22)
at (/mnt/c/Users/User/Desktop/props/tests/transistor.test.ts:14:39)
✗ should parse transistor props for npn transistor [11.01ms]
687 | }
688 | parse(data, params) {
689 | const result = this.safeParse(data, params);
690 | if (result.success)
691 | return result.data;
692 | throw result.error;
^
ZodError: [
{
"expected": "'npn' | 'pnp' | 'bjt' | 'jfet' | 'mosfet'",
"received": "undefined",
"code": "invalid_type",
"path": [
"type"
],
"message": "Required"
}
]
at parse (/mnt/c/Users/User/Desktop/props/node_modules/zod/lib/index.mjs:692:22)
at (/mnt/c/Users/User/Desktop/props/tests/transistor.test.ts:24:39)
✗ should parse transistor props for pnp transistor [9.57ms]
✓ should fail to parse transistor props with invalid transistor type [0.41ms]
✓ should enforce correct types for transistor props [0.10ms]

14 pass
2 fail
17 expect() calls

@Rishikesh63
Copy link
Author

@seveibar please review this PR

@Anshgrover23
Copy link
Contributor

resolved via #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants