Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+31
to
+50
|
|
||
| test("should allow null for cellBorder", () => { | ||
| const raw: BaseGroupProps = { | ||
| name: "g", | ||
| cellBorder: null, | ||
| } | ||
|
|
||
| const parsed = baseGroupProps.parse(raw) | ||
| expect(parsed.cellBorder).toBeNull() | ||
| }) | ||
|
|
||
| test("should allow null for border", () => { | ||
| const raw: BaseGroupProps = { | ||
| name: "g", | ||
| border: null, | ||
| } | ||
|
|
||
| const parsed = baseGroupProps.parse(raw) | ||
| expect(parsed.border).toBeNull() | ||
| }) |
Contributor
There was a problem hiding this comment.
It appears this PR adds multiple test cases to a single test file. Based on the project's conventions, each test file should contain only one test case. Consider splitting these into separate files (e.g., group1.test.ts, group2.test.ts, etc.) to maintain consistency with the project's testing structure.
Spotted by Diamond (based on custom rules)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cellBorderandborderto benullon<group />Testing
bun test tests/group.test.tsbun test testshttps://chatgpt.com/codex/tasks/task_b_684db5d31244832e82cc0ba3106ee78a