Add grid gaps to layout config, add pcbFlex#342
Merged
Conversation
Comment on lines
+151
to
+160
| test("should parse layout grid gaps", () => { | ||
| const raw: BaseGroupProps = { | ||
| name: "g", | ||
| gridRowGap: "1mm", | ||
| gridColumnGap: 2, | ||
| } | ||
| const parsed = baseGroupProps.parse(raw) | ||
| expect(parsed.gridRowGap).toBe("1mm") | ||
| expect(parsed.gridColumnGap).toBe(2) | ||
| }) |
Contributor
There was a problem hiding this comment.
It appears this PR adds a second test function to group.test.ts, which conflicts with the project's testing convention. Based on the existing structure, each test file should contain only one test() function.
Consider moving the new test to a separate file (e.g., group2.test.ts) to maintain consistency with the project's testing pattern. This approach helps keep test files focused and makes it easier to locate specific test cases.
// New file: group2.test.ts
test("should parse layout grid gaps", () => {
const raw: BaseGroupProps = {
name: "g",
gridRowGap: "1mm",
gridColumnGap: 2,
}
const parsed = baseGroupProps.parse(raw)
expect(parsed.gridRowGap).toBe("1mm")
expect(parsed.gridColumnGap).toBe(2)
})Spotted by Diamond (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gridRowGapandgridColumnGapto layout configzodTesting
bun test tests/group.test.tsbun testhttps://chatgpt.com/codex/tasks/task_b_6886c7a61e24832ea801fa8cc9c24624