Skip to content

Add grid gaps to layout config, add pcbFlex#342

Merged
seveibar merged 3 commits intomainfrom
codex/add-grid-and-pcb-gap-properties-to-layout
Jul 30, 2025
Merged

Add grid gaps to layout config, add pcbFlex#342
seveibar merged 3 commits intomainfrom
codex/add-grid-and-pcb-gap-properties-to-layout

Conversation

@seveibar
Copy link
Copy Markdown
Contributor

Summary

  • add gridRowGap and gridColumnGap to layout config
  • expose new PCB grid gap fields on group props
  • update generated docs
  • bump dev dependency zod
  • document and test the new props

Testing

  • bun test tests/group.test.ts
  • bun test

https://chatgpt.com/codex/tasks/task_b_6886c7a61e24832ea801fa8cc9c24624

@seveibar seveibar changed the title Add grid gaps to layout config Add grid gaps to layout config, add pcbFlex Jul 30, 2025
@seveibar seveibar merged commit ede9700 into main Jul 30, 2025
5 checks passed
@seveibar seveibar deleted the codex/add-grid-and-pcb-gap-properties-to-layout branch July 30, 2025 18:04
Comment thread tests/group.test.ts
Comment on lines +151 to +160
test("should parse layout grid gaps", () => {
const raw: BaseGroupProps = {
name: "g",
gridRowGap: "1mm",
gridColumnGap: 2,
}
const parsed = baseGroupProps.parse(raw)
expect(parsed.gridRowGap).toBe("1mm")
expect(parsed.gridColumnGap).toBe(2)
})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this PR adds a second test function to group.test.ts, which conflicts with the project's testing convention. Based on the existing structure, each test file should contain only one test() function.

Consider moving the new test to a separate file (e.g., group2.test.ts) to maintain consistency with the project's testing pattern. This approach helps keep test files focused and makes it easier to locate specific test cases.

// New file: group2.test.ts
test("should parse layout grid gaps", () => {
  const raw: BaseGroupProps = {
    name: "g",
    gridRowGap: "1mm",
    gridColumnGap: 2,
  }
  const parsed = baseGroupProps.parse(raw)
  expect(parsed.gridRowGap).toBe("1mm")
  expect(parsed.gridColumnGap).toBe(2)
})

Spotted by Diamond (based on custom rule: Custom rule)

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant