Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+39
to
+43
| test("should parse flex board material", () => { | ||
| const raw: BoardProps = { name: "board", material: "flex" } | ||
| const parsed = boardProps.parse(raw) | ||
| expect(parsed.material).toBe("flex") | ||
| }) |
Contributor
There was a problem hiding this comment.
The style guide states that a *.test.ts file may have AT MOST one test(...) call. This file already contained multiple tests before this PR, and adding another test("should parse flex board material", ...) further violates this rule. Each test should be placed in its own numbered file (e.g., board1.test.ts, board2.test.ts, board3.test.ts, etc.) so that no single test file contains more than one test(...) block.
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
"flex"to theBoardProps.materialTypeScript type and to theboardPropsZod enum inlib/components/board.tswhile keeping the default as"fr4".generated/COMPONENT_TYPES.md,generated/PROPS_OVERVIEW.md, andREADME.mdreflect the new"flex"option.tests/board.test.tsthat validates parsingmaterial: "flex"withboardProps.Testing
bun scripts/generate-component-types.ts,bun scripts/generate-manual-edits-docs.ts,bun scripts/generate-readme-docs.ts, andbun scripts/generate-props-overview.ts, each completed successfully.bun test tests/board.test.ts, which passed (12 tests, 0 failures).bunx tsc --noEmitand formatting withbun run format, both completed successfully.Codex Task