Skip to content

Remove unsupported cornerRadius from schematic rect props#686

Merged
rushabhcodes merged 2 commits into
tscircuit:mainfrom
rushabhcodes:codex/remove-unsupported-corner-radius-schematic-rect
Jun 3, 2026
Merged

Remove unsupported cornerRadius from schematic rect props#686
rushabhcodes merged 2 commits into
tscircuit:mainfrom
rushabhcodes:codex/remove-unsupported-corner-radius-schematic-rect

Conversation

@rushabhcodes
Copy link
Copy Markdown
Contributor

Summary

Remove cornerRadius from SchematicRectProps and the schematic rect schema so schematic rectangles only expose supported props.

What changed

  • Removed cornerRadius from lib/components/schematic-rect.ts
  • Added a regression test that confirms schematic rect parsing does not expose cornerRadius
  • Regenerated the component type and props overview docs so the generated artifacts stay in sync

Validation

  • bun scripts/generate-component-types.ts
  • bun scripts/generate-manual-edits-docs.ts
  • bun scripts/generate-readme-docs.ts
  • bun scripts/generate-props-overview.ts
  • bun test tests/schematic-rect.test.ts

@rushabhcodes rushabhcodes marked this pull request as ready for review May 31, 2026 18:08
Copilot AI review requested due to automatic review settings May 31, 2026 18:08
@rushabhcodes rushabhcodes changed the title [codex] Remove unsupported cornerRadius from schematic rect props Remove unsupported cornerRadius from schematic rect props May 31, 2026
Comment thread tests/schematic-rect.test.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Abse2001
Copy link
Copy Markdown
Contributor

Abse2001 commented Jun 3, 2026

@rushabhcodes why are you removing it ? we don't want to support it ?

@rushabhcodes
Copy link
Copy Markdown
Contributor Author

yeah, @seveibar said we need to remove it, it was added 6 months ago by nailoo, we cant find any real world use case for it.
image

@rushabhcodes rushabhcodes merged commit 5a15eaa into tscircuit:main Jun 3, 2026
5 checks passed
@rushabhcodes rushabhcodes deleted the codex/remove-unsupported-corner-radius-schematic-rect branch June 3, 2026 05:13
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants