Remove unsupported cornerRadius from schematic rect props#686
Merged
rushabhcodes merged 2 commits intoJun 3, 2026
Conversation
Contributor
|
@rushabhcodes why are you removing it ? we don't want to support it ? |
Contributor
Author
|
yeah, @seveibar said we need to remove it, it was added 6 months ago by nailoo, we cant find any real world use case for it. |
Abse2001
approved these changes
Jun 3, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remove
cornerRadiusfromSchematicRectPropsand the schematic rect schema so schematic rectangles only expose supported props.What changed
cornerRadiusfromlib/components/schematic-rect.tscornerRadiusValidation
bun scripts/generate-component-types.tsbun scripts/generate-manual-edits-docs.tsbun scripts/generate-readme-docs.tsbun scripts/generate-props-overview.tsbun test tests/schematic-rect.test.ts