feat: Add RectDiffPipeline with BasePipelineSolver #30
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
This adds confusion. RectDiffSolver IS a pipeline, but not using our standard class. It has a “phase” variable but doesnt properly use subsolvers. This is possibly mergable if it is the first step towards removing RectDiffState, RectDiffSolver etc and breaking down the phases into separate solvers
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
See prev comment, it is good to move fwd
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
No description provided.