feat: tailwind prefix + latest shadcn component #146
feat: tailwind prefix + latest shadcn component #146ArnavK-09 wants to merge 6 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArnavK-09
changed the title
|
@ArnavK-09 really nice work, will be pulling and testing this shortly, when i tried to do this i found a lot of little tiny errors on the page, but your work here looks correct |
|
I'll wait for the response, btw any way to fix conflict? |
|
@ArnavK-09 yes to resolve conflict you just do Actually could you merge the latest main? It should fix your preview deployment. |
|
Ohh an too bad at git stuff, any fix or should create new pr? Maybe because I updated PKG json for latest shadn |
|
Hey @seveibar sorry for issues, I tried to resolve commit, can you review and proceed to merge it valid? Thanks |
|
i found this issue with border radiuses. Did you regenerate the shadcn components using the cli?
CC @imrishabh18 if this prefix method works we could theoretically use this instead of twind for libraries, although twind is a bit cleaner imo |
Oh yes, i regenerated with shadcn to get latest version, it also generated some radius css variables, i deleted them, my bad |
|
yes let's bring back the variables so that the radiuses are correct, regenerating was the right way to do it fwiw 👍 |
I just noticed that updating shadcn components to latest version also updated some styling of shadcn components included heights and radius, I tried to revert radius style of tabs as before! If any other styling you want as before lemme know, I'll wait for approval |
|
err, looks like it's not right yet Your Update
Last Released Version
|
|
@ArnavK-09 if you look at the screenshots you can see the padding is wrong. I don't care whether or not this changes- it's fine to use the latest shadcn version OR to not change from the existing style, but the padding around the tab being off hints that we may possibly have an issue with padding in other places (just want to make sure we load everything in properly) |
|
I'm not sure if it's clear but the X padding does not match the Y padding. We'd like to use the latest version of shadcn without modifications, but it seems like it might not be loading properly |
|
From the shadcn homepage, also uniform padding around the active tab
|
|
I know it's a million comments at this point but for emphasis: please don't try to fix the padding or change ANY shadcn styles or adapt them to match the old ones etc. We want to use shadcn without modifications, but the tab issue is just a hint that it's not loaded properly |
|
fwiw i updated the components on your branch and for whatever reason it didn't really work, a bunch of styles were lost (!)
So i don't completely know what's going on here... |
|
been working on this for an hour or so now, closing but will allow you to get a partial claim, TBA shortly |
so should i continue to resolve these issues or not? |
it maybe because i manually changed height after installation latest components, if you want i try to fix these issues, but better to let me know if you plan to close this pr or not so that i can continue to resolve these issues, thnks |
|
closing in favor #149 , thanks @ArnavK-09 !!! |
2 participants
/claim #145