Simplify BOM table rendering#3187
Merged
rushabhcodes merged 3 commits intotscircuit:mainfrom Apr 24, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR refactors BomTable to render directly from structured BOM rows produced by convertCircuitJsonToBomRows, replacing the previous approach of deriving table columns/rows from source_component elements.
Changes:
- Switched BOM table rendering to use
convertCircuitJsonToBomRows(circuitJson)output. - Added metadata/descriptor helpers to drive header + body from a shared column descriptor list.
- Preserved JLCPCB part-number linking and support for manufacturer/MPN plus extra columns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
imrishabh18
reviewed
Apr 22, 2026
Member
imrishabh18
left a comment
There was a problem hiding this comment.
Split the code in separate files
seveibar
approved these changes
Apr 24, 2026
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites BomTable to render directly from the structured BOM rows returned by circuit-json-to-bom-csv instead of deriving the table from source_component elements.
Before
After