Fix package details dialog stacking in Import Component flow#3197
Merged
rushabhcodes merged 4 commits intotscircuit:mainfrom Apr 23, 2026
Merged
Fix package details dialog stacking in Import Component flow#3197rushabhcodes merged 4 commits intotscircuit:mainfrom
rushabhcodes merged 4 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
why is the zIndex this high?
Contributor
Author
the search dialog is already having a z index of 101 so i am keeping 102 |
imrishabh18
requested changes
Apr 22, 2026
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
Don't hardcode the z-index, I remember there is some file which maintains the z-index's of component add there and then use it here
Contributor
Author
|
@imrishabh18 is the naming ok ? |
Member
No, can you make it more descriptive. Even the other property name is not good enough |
seveibar
approved these changes
Apr 22, 2026
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Screen.Recording.2026-04-23.at.12.46.46.AM.mov
After:
Screen.Recording.2026-04-23.at.12.45.58.AM.mov
Fixes the Import Component package details view so clicking “See Details” no longer appears broken when the details dialog opens behind the search dialog.
The issue was caused by the search dialog using a higher z-index than the package details dialog, which left the details dialog mounted but hidden in the visual stack. This change raises the details dialog z-index above the search dialog.