fix: highlight same-net schematic traces on hover#182
Open
time-turner42 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
I updated the PR body with the Algora claim commands for tscircuit/tscircuit#1130. Preview is ready here: https://schematic-viewer-git-fork-time-turner42-fix-tr-3c85cc-tscircuit.vercel.app Checks are passing and the PR is mergeable. If this satisfies the hover-highlight bounty, could a maintainer please review/merge/reward? I am available for quick changes. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim tscircuit/tscircuit#1130
/fixes tscircuit/tscircuit#1130
Summary
Fixes same-net schematic trace hover highlighting for tscircuit/tscircuit#1130.
useTraceNetHoverHighlightto map rendered schematic trace DOM nodes back to theirsource_trace_id.SchematicViewer.Test Plan
npm_config_userconfig=/dev/null npx tsc --noEmitgit diff --checkBounty / issue
Refs tscircuit/tscircuit#1130
Algora board listed this issue as a $25 open bounty at time of work. Please confirm bounty eligibility/claim requirements.