Fix support for message flags #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capcom6
changed the title
capcom6
force-pushed
the
bugfix/flags-without-file-support
branch
from
c35a85a to
bb56609
Compare
|
Would love to see this implemented as well. |
Contributor
Author
|
@zbee , for now you can use updated version from my repository |
tsickert
approved these changes
Mar 1, 2025
Owner
|
Sincere apologies for the delayed review, thanks so much for the contribution! 🙏 |
Owner
|
v7.0.0 is released with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the action fails with a
400response code when using flags. This limitation makes it impossible to send messages with links without embedding them, which can be controlled by theSUPPRESS_EMBEDSflag.Solution
Include message flags in the request payload when sending as JSON, not only
multipart/form-data.Changes
flagsandthread_nameinTOP_LEVEL_WEBHOOK_KEYSflagsandthreadNameformultipart/form-datamethodSUPPRESS_EMBEDSflagTesting
SUPPRESS_EMBEDSflagAdditional Notes
This change enhances the flexibility of the action, allowing users to have more control over message appearance and behavior.