FIR-214: Add reserved memory area beginning 0x56A0_000 of 512 MB and Enable NVME #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2024 15:15
This change adds a 512 MB contiguous memory area for model data Moved the reserved area from 0x7f100000 to 0x56A00000 and fixed the size to 512MB
Added back to PCI-E config This change has been validated in a combined image of NVME and DDR based command queue
atrivedi-tsavoritesi
requested review from
DashingR,
akapoor3518,
dmpatra,
mmankal and
tsavoritesi-vgarg
mmankal
approved these changes
Oct 16, 2024
Collaborator
mmankal
left a comment
mmankal
left a comment
There was a problem hiding this comment.
Would have liked to commit the DDR_ACCESS removal/NVME as part of my irq -enable test since I have already tested for it.. but since you've included with this commit.. approved with reservation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes do two following changes