Add x_label parameter for the X axis
#1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyanwong
force-pushed
the
svg-x-label
branch
from
e5d2699 to
fabe6a5
Compare
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 26 26
Lines 21516 21518 +2
Branches 905 906 +1
=======================================
+ Hits 20166 20168 +2
Misses 1312 1312
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Looks good. I can't see any x-label in the example when I view it on github (and search this page for "genomic position" doesn't hit anything in the xml, so I'm not sure it's actually worked?
And correct some alignment bugs in SVG placement of trees in a tree sequence
hyanwong
force-pushed
the
svg-x-label
branch
from
fabe6a5 to
00767e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And correct some alignment bugs in SVG placement of trees in a tree sequence, where we accidentally padded the top of the trees in the tree sequence, rather than just the bottom.
This will result in nicer diagrams for the tutorial, and is an obvious addition. The only question is whether we want a label by default or not. It's less of a change, and less language-specific if we simply have no X label by default, so I just left it that way for the time being.
Visual representations to check this is what we want are in the
tests/data/svgdirectory.PR Checklist: