Skip to content

Conversation

benjeffery
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.82%. Comparing base (99f03e2) to head (576fde3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/tskit/metadata.py 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3287      +/-   ##
==========================================
- Coverage   89.84%   89.82%   -0.02%     
==========================================
  Files          29       29              
  Lines       32719    32665      -54     
  Branches     5988     5982       -6     
==========================================
- Hits        29396    29342      -54     
  Misses       1882     1882              
  Partials     1441     1441              
Flag Coverage Δ
c-tests 86.86% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.40% <ø> (ø)
python-tests 98.76% <98.71%> (-0.01%) ⬇️
python-tests-no-jit 33.18% <28.20%> (+0.13%) ⬆️
python-tests-numpy1 50.84% <30.76%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/tables.py 99.29% <100.00%> (+0.03%) ⬆️
python/tskit/metadata.py 98.89% <97.36%> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery benjeffery force-pushed the phase1 branch 4 times, most recently from e0a505a to 9ee3ae1 Compare September 26, 2025 14:02
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming this is all basically the same code except refactored into a mixin?

@benjeffery
Copy link
Member Author

LGTM. I'm assuming this is all basically the same code except refactored into a mixin?

Yep

@benjeffery benjeffery added this pull request to the merge queue Sep 29, 2025
Merged via the queue into tskit-dev:main with commit 6115308 Sep 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants