Skip to content

Conversation

@charavelg
Copy link
Contributor

No description provided.

@charavelg charavelg linked an issue Sep 16, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (cd3ec24) to head (f401796).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   90.09%   90.48%   +0.38%     
==========================================
  Files          67       68       +1     
  Lines        6089     6261     +172     
==========================================
+ Hits         5486     5665     +179     
+ Misses        603      596       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charavelg charavelg requested a review from rtavenar September 18, 2025 12:04
@rtavenar
Copy link
Member

In KNeighborsTimeSeriesMixin.kneighbors: I guess you should add cdist_frechet there. Also, this bit of code is easily missed when adding a new metric. If we had a dict mapping distance names to cdist functions, we could use it there maybe?

@rtavenar
Copy link
Member

Last but not least, could you work on a simple example for the docs?

I guess you could adapt the CTW example in several ways:

  • do not rotate the series
  • add noise
  • use one color for the links along the matching path and another color for the link that connects the pair with maximal distance (which can be found by iterating over the path in a loop)

@charavelg charavelg changed the title [WIP] Add frechet metric Add frechet metric Sep 29, 2025
@charavelg charavelg merged commit d6846d3 into main Sep 29, 2025
31 checks passed
@charavelg charavelg deleted the 402-frechet-distance-implementation-in-tslearn branch September 29, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fréchet distance implementation in tslearn

3 participants