[log_ref] support for stack traces and some engineering #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack traces are not part of a log message format string, so we need to separate them out. This change adds a regex that is run over the body to pull out Python/Java backtraces. If a trace is detected, it is stored in the
tracefield of theLogDetailsstruct. Thebodyfield will then only contain the message body without the trace.In order to support this, though, the CLI needed to be modified to handle multi-line messages. So, the binary now reads input line-by-line and checks if it matches the log format. If it does, it's considered the start of a new message. If the next line/EOF also matches the format, then we process the message. Otherwise, we add the line to the previous lines to be processed later.
Files: