pr feat: 뉴스레터 api 구현 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
확인했습니다 뉴스레터 구현하시느라 수고하셨습니다 |
Contributor
why-only-english
left a comment
why-only-english
left a comment
There was a problem hiding this comment.
뉴스레터 기능 구현 고생하셨습니다!
Comment on lines
+86
to
+92
| private static List<ImageRes> getImageResponses(final Newsletter newsletter) { | ||
| List<NewsletterImage> newsletterImages = newsletter.getNewsletterImageList(); | ||
| return newsletterImages | ||
| .stream() | ||
| .map(ImageRes::toDto) | ||
| .toList(); | ||
| } |
Contributor
There was a problem hiding this comment.
stream을 사용하여 응답 요청을 받을 때 장점이 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number and Link
이슈 번호 : #28
Summary
뉴스레터 api를 구현하였습니다.
PR Type
Other Information
Common Type
branch