pr Docs/2 honeytip swagger #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
확인했습니다! |
toychip
requested changes
Jan 12, 2024
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
toychip
reviewed
Jan 24, 2024
Member
toychip
left a comment
toychip
left a comment
There was a problem hiding this comment.
재혁님 코드 확인했습니다.
저번 저의 의견 반영해주셔서 감사합니다!
| package com.api.ttoklip.domain.honeytip.main.domain; | ||
|
|
||
| public enum Category { | ||
| HOUSEWORK, RECIPE, SAFE_LIVING, WELFARE_POLICY |
Member
There was a problem hiding this comment.
enum을 더 의미있게 사용해보는 것은 어떨까요?
아래와 같이 사용하면 더 많은 정보들을 유연하게 활용할 수 있을 것 같습니다!
// 예시..
HOUSEWORK("집안일", 1),
RECIPE("요리", 2),
SAFE_LIVING("안전한 생활", 3),
WELFARE_POLICY("복지 정책", 4);
private final String name;
private final int code;
Category(String name, int code) {
this.name = name;
this.code = code;
}
Contributor
Author
There was a problem hiding this comment.
@AllArgsConstructor
@Getter
를 사용해도 좋을 것 같아요.
|
|
||
| public HoneytipMainRes main() { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
해당 메인의 기능이 제가 담당한 '질문해요'와 기능이 같은 것 같습니다. 그 중, 꿀팁의 메인 기능과 질문해요의 메인 기능을 합치는 ParenetMain과 같은 클래스를 만들어서 객체화하면 좋을 것 같은데 재혁님 의견이 궁금합니다.
Contributor
Author
There was a problem hiding this comment.
기능이 겹치는 부분은 합치는게 좋다고 생각합니다.
| value = HoneytipResponseConstant.honeytipValue, | ||
| description = "인기 꿀팁 Top 5와 카테고리별 3개가 한번에 응답으로 나갑니다." | ||
| )))}) | ||
| @GetMapping |
| @Service | ||
| @RequiredArgsConstructor | ||
| public class HoneytipPostService { | ||
| public Long register(HoneytipCreateReq request) { |
Member
There was a problem hiding this comment.
parameter에 final 키워드를 추가하여 불변성을 지키면 좋을 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
final 키워드 추가하였습니다.
toychip
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number and Link
이슈 번호 : #4
Summary
PR Type
Other Information
Common Type
branch