Conversation
…ontroller, and summary screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several important improvements to project policies, documentation, and testing infrastructure for the Simplications Flutter app. The main focus is on formalizing build number policies for both human and AI contributors, clarifying localization and persistence requirements, and significantly expanding automated test coverage for core features.
Key changes include:
Policy and Documentation Updates
AGENTS.mdas the definitive policy file for AI agents, specifying that any change to core app files underlib/requires incrementing the build number inpubspec.yaml, and detailing what constitutes a core file and how to bump the version. ([AGENTS.mdR1-R132](https://github.com/tucmi/simplications/pull/5/files#diff-a54ff182c7e8acf56acfd6e4b9c3ff41e2c41a31c9b211b2deb9df75d9a478f9R1-R132)).llmrcto clarify the precedence ofAGENTS.md, document the build number policy for LLM edits, reflect the now-active multi-language UI and SharedPreferences-based persistence, and update submission and QA checklists to require localization across all supported locales. ([[1]](https://github.com/tucmi/simplications/pull/5/files#diff-1a218f851ad253f775831920fc9e3f8d6f27e8cc162940fa7620dcb48bfa244dR5-R15),[[2]](https://github.com/tucmi/simplications/pull/5/files#diff-1a218f851ad253f775831920fc9e3f8d6f27e8cc162940fa7620dcb48bfa244dL117-R131),[[3]](https://github.com/tucmi/simplications/pull/5/files#diff-1a218f851ad253f775831920fc9e3f8d6f27e8cc162940fa7620dcb48bfa244dL141-R154),[[4]](https://github.com/tucmi/simplications/pull/5/files#diff-1a218f851ad253f775831920fc9e3f8d6f27e8cc162940fa7620dcb48bfa244dL183-R196),[[5]](https://github.com/tucmi/simplications/pull/5/files#diff-1a218f851ad253f775831920fc9e3f8d6f27e8cc162940fa7620dcb48bfa244dL222-R235),[[6]](https://github.com/tucmi/simplications/pull/5/files#diff-1a218f851ad253f775831920fc9e3f8d6f27e8cc162940fa7620dcb48bfa244dL263-R277))CONTRIBUTING.md, reinforcing the requirement for version bumps on any core file changes and cross-referencing the newAGENTS.mdpolicy. ([CONTRIBUTING.mdR96-R111](https://github.com/tucmi/simplications/pull/5/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R96-R111))Versioning
pubspec.yamlfrom1.0.0+1to1.0.0+2to comply with the new policy after core file changes. ([pubspec.yamlL20-R20](https://github.com/tucmi/simplications/pull/5/files#diff-8b7e9df87668ffa6a04b32e1769a33434999e54ae081c52e5d943c541d4c0d25L20-R20))Automated Testing
test/app_localizations_test.dart), device risk scoring logic (test/device_risk_scoring_test.dart), language controller persistence and locale switching (test/language_controller_test.dart), and summary screen rendering and logic (test/summary_screen_test.dart). ([[1]](https://github.com/tucmi/simplications/pull/5/files#diff-9cd14444d1f8095a3a26052974d6ebfb59f4855a3df769b2a3dc8e7c7821f0f0R1-R57),[[2]](https://github.com/tucmi/simplications/pull/5/files#diff-931e43dced578414b91d5611b2bb5ad0b7ae5f0b764a915e5e1f6058a9caf09bR1-R109),[[3]](https://github.com/tucmi/simplications/pull/5/files#diff-ae093e72975e779f5fd136508e3045c6a5ada814b7a17eec91154e4499e04ec5R1-R55),[[4]](https://github.com/tucmi/simplications/pull/5/files#diff-3231ed26d662f7813efde3bff889603cedd59ecbabae17e0e47a663c3897888aR1-R83))These changes collectively improve project maintainability, ensure consistent versioning for releases, and increase confidence in core app functionality through robust automated testing.
Type of change
Checklist
flutter analyzepasses with no new issuesflutter testpasses