[NFC] Rename CGCollector_VERSION_* macros to MetaCG_VERSION_*#26
Merged
TimHeldmann merged 1 commit intotudasc:develfrom May 2, 2025
Merged
Conversation
Member
|
I believe the original intent was the result of potential changes to the file format and the collector capabilities on separate versions. I agree that this is obsolete by now and we should only have one version for everything. |
TimHeldmann
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the macros
CGCollector_VERSION_MAJORandCGCollector_VERSION_MINORtoMetaCG_VERSION_MAJORandMetaCG_VERSION_MINOR, respectively.@TimHeldmann Am I overlooking any reason why we would still need the
CGCollectorin the macro names or this just a leftover from old CGCollector versions?