Merged
Conversation
jplehr
approved these changes
Jul 6, 2025
Member
jplehr
left a comment
There was a problem hiding this comment.
Thanks, that's cool stuff.
For the future: we can also think of generating some long strings as names, since the older formats are showing real slowness with long strings and they are quite common for C++ mangled names.
Member
|
I forgot one thing: can you update the commit title to be something like [Graph] Add initial performance tests Or something like that? Thank you. |
efe2d09 to
ce2d501
Compare
Member
Author
Yes, I'll try that out. Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds performance tests for the graph lib. I wrote this as a weekend project to be able to evaluate the performance differences of the upcoming graphlib re-write.
As a follow-up, this can be integrated into the CI to catch performance regressions.
Usage:
./perftest <num_nodes> <num_edges> <rng_seed>Results for current
develon my laptop: