Fix PGIS regression due to cxxopts update#72
Merged
pearzt merged 2 commits intotudasc:develfrom Aug 8, 2025
Merged
Conversation
Co-authored-by: Tim Heldmann <tim.heldmann@tu-darmstadt.de> Co-authored-by: Sebastian Kreutzer <sebastian.kreutzer@tu-darmstadt.de>
Member
|
LGTM, why is this marked as draf? |
Member
Author
|
Maybe it looked good, but it wasn't working yet, that's why it was a draft. I think I've fixed it now. Downstream CI is running now. |
TimHeldmann
approved these changes
Aug 8, 2025
|
|
||
| ```{.sh} | ||
| $> pgis_pira --metacg-format 2 --parameter-file <parameter-file> --lide 1 --cube cube-file mcg-file | ||
| $> pgis_pira --metacg-format 2 --parameter-file <parameter-file> --lide --cube cube-file mcg-file |
Member
There was a problem hiding this comment.
Why is this 1 getting removed?
Iirc this is load imbalance dectection?
Member
Author
There was a problem hiding this comment.
--lide is a boolean option (either it's present or it's not), so the 1 was unnecessary even before, but was just ignored. With the new parsing logic based on a positional argument the 1 was being wrongfully parsed as the MetaCG input file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to fix regression that I introduced in #68