[NFC] Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to make json work with newer CMake#9
Merged
jplehr merged 1 commit intotudasc:develfrom Apr 2, 2025
Conversation
sebastiankreutzer
force-pushed
the
fix/json_cmake_compatibility
branch
from
38ef1cc to
396f575
Compare
Member
|
LGTM |
jplehr
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github CI is broken, because compatibility with CMake >3.5 was removed in the latest CMake release. This adds
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to the CI build as a workaround.