Skip to content

fix(oauth2): use found instead of accepted #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(oauth2): use found instead of accepted #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/oauth2/oauth2.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class Oauth2Controller {
@Get('microsoft/callback')
@ApiResponse({
description: 'Redirects to the frontend with the JWT token',
status: HttpStatus.ACCEPTED,
status: HttpStatus.FOUND,
})
@ApiNotFoundResponse({
description: 'OAuth2 is not enabled for Microsoft',
Expand Down Expand Up @@ -123,7 +123,7 @@ export class Oauth2Controller {
@Get('google/callback')
@ApiResponse({
description: 'Redirects to the frontend with the JWT token',
status: HttpStatus.ACCEPTED,
status: HttpStatus.FOUND,
})
@ApiNotFoundResponse({
description: 'OAuth2 is not enabled for Google',
Expand Down Expand Up @@ -159,7 +159,7 @@ export class Oauth2Controller {
@Get('facebook/callback')
@ApiResponse({
description: 'Redirects to the frontend with the JWT token',
status: HttpStatus.ACCEPTED,
status: HttpStatus.FOUND,
})
@ApiNotFoundResponse({
description: 'OAuth2 is not enabled for Facebook',
Expand Down Expand Up @@ -195,7 +195,7 @@ export class Oauth2Controller {
@Get('github/callback')
@ApiResponse({
description: 'Redirects to the frontend with the JWT token',
status: HttpStatus.ACCEPTED,
status: HttpStatus.FOUND,
})
@ApiNotFoundResponse({
description: 'OAuth2 is not enabled for GitHub',
Expand Down Expand Up @@ -271,7 +271,7 @@ export class Oauth2Controller {
});

return res
.status(HttpStatus.ACCEPTED)
.status(HttpStatus.FOUND)
.redirect(`${this.url}/auth/callback?${urlSearchParams.toString()}`);
}
}
4 changes: 2 additions & 2 deletions test/oauth2.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ describe('OAuth2 (e2e)', () => {
const name = faker.person.fullName();
const email = faker.internet.email().toLowerCase();

it('should return 202 accepted and redirect with code', async () => {
it('should return 302 FOUND and redirect with code', async () => {
const frontendUrl = `https://${configService.get<string>('domain')}/auth/callback`;
await cacheManager.set(`oauth_state:${state}`, provider, 120_000);
const tokenScope = nock(host, {
Expand Down Expand Up @@ -171,7 +171,7 @@ describe('OAuth2 (e2e)', () => {

await request(app.getHttpServer())
.get(`${callbackPath}?code=${code}&state=${state}`)
.expect(HttpStatus.ACCEPTED)
.expect(HttpStatus.FOUND)
.expect((res) => {
expect(res.headers.location.startsWith(frontendUrl)).toBe(true);

Expand Down