fix: replace blocking waitUntilExit with async terminationHandler to prevent thread starvation#249
Merged
Merged
Conversation
terminationHandler to prevent thread pool starvation
Member
|
Added a regression test in What changed:
Local verification:
This gives us a TDD-style regression check: old behavior hangs, fixed behavior drains the pipes and completes. |
pepicrft
approved these changes
May 8, 2026
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
process.waitUntilExit()withprocess.terminationHandler+CheckedContinuationto avoid blocking the cooperative thread poolProblem
CommandRunner.run()executes inside aTask.detached, which runs on Swift's cooperative thread pool. The call toprocess.waitUntilExit()blocks that thread until the subprocess finishes. When multiple commands run concurrently (e.g., during manifest loading in a large monorepo), each blocked thread reduces pool capacity. Once all pool threads are occupied bywaitUntilExit()calls, thestdoutTaskandstderrTaskpipe-reading tasks can never be scheduled. The subprocesses then fill their pipe buffers and block on write, whilewaitUntilExit()waits for processes that can never finish — a classic thread starvation deadlock.This causes tuist generate and tuist test to hang indefinitely at "Loading and constructing the graph" in large repos.
Fix
Replace the blocking
waitUntilExit()with an async-friendlyterminationHandlerthat suspends the task viaCheckedContinuation. This frees the pool thread while waiting for the process to exit, allowing pipe-draining tasks to be scheduled normally.