feat: not resolve executables that are already passed as absolute paths#80
Merged
AndrewBarba merged 8 commits intotuist:mainfrom Aug 11, 2024
Merged
Conversation
Collaborator
AndrewBarba
commented
Aug 10, 2024
AndrewBarba
commented
- Detect an absolute executable path
- Properly set environment
pepicrft
changed the title
pepicrft
approved these changes
Aug 11, 2024
Contributor
pepicrft
left a comment
pepicrft
left a comment
There was a problem hiding this comment.
@AndrewBarba thanks for fixing this 🙏🏼. Do you mind adding an integration tests that covers this scenario and resolving the conflicts? We can merge right after if CI is green.
Contributor
|
@all-contributors add @AndrewBarba for code |
Contributor
|
I've put up a pull request to add @AndrewBarba! 🎉 |
Collaborator
Author
|
@pepicrft All set! Thanks so much |
Contributor
|
Thanks a lot @AndrewBarba 🙏🏼 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.