Skip to content

Conversation

@alexanderwe
Copy link
Contributor

@alexanderwe alexanderwe commented Feb 17, 2025

📝 Description

This PR fixes the encoding of XCFrameworkInfoPlist.

When encoding the XcodeGraph.Graph type it appears to miss the platform property. This leads to decoding Issues when decoding the data again.

@alexanderwe
Copy link
Contributor Author

@fortmarek I did not modify any tests since there are no decoding tests for the type. Would you like to have Encoding/Decoding unit tests or is this rather something you do not want to do for this library ?

@fortmarek
Copy link
Member

Thanks for the PR @alexanderwe!

Would you like to have Encoding/Decoding unit tests or is this rather something you do not want to do for this library ?

There are plenty of tests for codability of different models, so yes, I'd add tests for this one, too, if you don't mind 😌

@alexanderwe
Copy link
Contributor Author

Thanks for the PR @alexanderwe!

Would you like to have Encoding/Decoding unit tests or is this rather something you do not want to do for this library ?

There are plenty of tests for codability of different models, so yes, I'd add tests for this one, too, if you don't mind 😌

Sure no problem, I have added a test for checking that coddle implementation is correct now

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fortmarek fortmarek changed the title fix: Fix encoding of XCFrameworkInfoPlist fix: encoding of XCFrameworkInfoPlist Feb 19, 2025
@fortmarek fortmarek merged commit 9c74696 into tuist:main Feb 19, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants