feat: add traits field to PackageConditionDescription #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows decoding trait conditions from Swift Package manifests. When a package dependency has a condition like `.when(traits: ["SQLCipher"])`, the traits array will now be properly decoded.
dosubot
bot
added
the
size:XS
pepicrft
requested review from
a team,
cschmatzler and
fortmarek
and removed request for
a team
fortmarek
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
traitsfield toPackageConditionDescriptionto support decoding trait conditions from Swift Package manifests.when(traits: ["SQLCipher"]), the traits array will now be properly decodedThis is needed to fix tuist/tuist#9218 where Tuist fails to generate projects for packages using SPM traits like SQLite.swift with the SQLCipher trait.