IMT-180 Optimize batch_actions system spec#375
Merged
Conversation
- Tighten setup and example scope - reduce eager test setup by converting shared fixtures from `let!` to lazy `let` - remove unused factory setup from the spec - scope record creation to the examples that actually need assets, statuses, and collections - replace repeated inline selection-change JavaScript with a shared helper - centralize page setup in a helper that waits for the batch-actions Stimulus controller - eliminate fixed `sleep` calls in favor of condition-based assertions - run the initial hidden-button example without JS via `rack_test` to avoid unnecessary browser overhead - keep the change scoped to `spec/system/batch_actions_spec.rb`
nomadicoder
changed the title
sensei100
reviewed
May 7, 2026
sensei100
requested changes
May 7, 2026
Contributor
sensei100
left a comment
sensei100
left a comment
There was a problem hiding this comment.
I would prefer that we keep our JS tests driven by cuprite.
sensei100
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let!to lazyletsleepcalls in favor of condition-based assertionsrack_testto avoid unnecessary browser overheadspec/system/batch_actions_spec.rb