notifications and app icon #28
Conversation
There was a problem hiding this comment.
Very good work! Appreciate it a ton. There are some minor things that should be fixed which you can see in the attached PR review.
Also, in order for the PR to be approved and completed, UI elements must be added and implemented in the event view sheet that let the user actually set and unset the notifications.
app/src/main/java/tumble/app/tumble/data/notifications/NotificationManager.kt
Show resolved
Hide resolved
app/src/main/java/tumble/app/tumble/extensions/models/NetworkResponseEventExtensions.kt
Show resolved
Hide resolved
app/src/main/java/tumble/app/tumble/extensions/models/NetworkResponseScheduleExtensions.kt
Show resolved
Hide resolved
app/src/main/java/tumble/app/tumble/presentation/viewmodels/AccountViewModel.kt
Show resolved
Hide resolved
|
Hey Nikolas, Everything looks good. However, we still need the actual UI elements implemented on each Event (i.e., the actual option to set a notification) |
|
I think this should already exits, commit 142e211 by @SvenLindstrom included the notification buttons. |
|
Oh and to get those buttons to show up you have to manually turn on the notifications trough the android settings. I thought the request to turn them on should probably be included with the on-boarding feature, if you want I can add a method that can be called to request permissions for notifications. |
2 participants
Implemented the notification flow, similar to the ios version #6
Added the app icon aswell #18