crypto: doc-deprecate multiple Hmac.digest() calls (DEP0206)#30
Open
crypto: doc-deprecate multiple Hmac.digest() calls (DEP0206)#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author: @Anshikakalpana
Fixes: nodejs#62838
Situation
Calling
digest()on an already-finalizedHmacinstance currently returns an empty buffer silently instead of throwing an error. This is inconsistent withHashbehavior which throwsERR_CRYPTO_HASH_FINALIZEDand is a potential security footgun.Change
Add a runtime deprecation warning (DEP0206) when
digest()is called more than once on anHmacinstance. The existing behavior (returning an empty buffer) is preserved during the deprecation cycle to avoid breaking changes.