feat(sdk-ts): migrate build to Vite with dual ESM+CJS output#4
Merged
Conversation
Fixes #3. Replace tsc with vite build (library mode) to emit both dist/index.js (ESM) and dist/index.cjs (CJS) from a single source. - Use import.meta.url + variable ref to avoid Vite inlining polyhook.wasm - Add fixCjsImportMetaUrl plugin: Rolldown (Vite 8) emits {}.url for import.meta.url in CJS chunks; patch it to require('url').pathToFileURL(__filename).href - Update package.json exports with import/require conditions and module field - Switch tsconfig to ESNext/bundler for Vite compatibility Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add ESM/CJS note, CJS usage example, and API reference table. Update gen-readmes.sh as the source of truth. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
Summary
tscbuild withvite build(library mode), emittingdist/index.js(ESM) anddist/index.cjs(CJS) from a single sourcepackage.jsonexports to include both"import"and"require"conditions — ESM consumers no longer need thecreateRequireworkaroundconst _wasmRel = '../polyhook.wasm') to prevent Vite from inlining the binary as a base64 data URLfixCjsImportMetaUrlRolldown plugin: Vite 8's Rolldown emits{}.urlforimport.meta.urlin CJS chunks; the plugin patches it torequire('url').pathToFileURL(__filename).hrefmoduletoESNext+moduleResolution: bundlerfor Vite compatibility; addstypecheckscriptTest plan
pnpm buildinpackages/sdk-ts— verifydist/index.js(~1.8 kB) anddist/index.cjs(~2 kB) exist with no WASM inliningpnpm test— all 19 tests passimport { read } from '@polyhook/sdk'works withoutcreateRequireworkaroundrequire('@polyhook/sdk')continues to work🤖 Generated with Claude Code