chore(rust): deny clippy::all and warnings workspace-wide#7
Merged
Conversation
Fix all pre-existing clippy violations so the deny level compiles clean: - Remove uninitialised Vec (uninit_vec) in wasm::alloc - Use const-init thread_local syntax (missing_const_for_thread_local) - Add # Safety docs to all pub unsafe extern "C" fns (missing_safety_doc) - Drop redundant .clone() on Copy CallerKind (clone_on_copy) - Allow derivable_impls on hand-written Default for generated CallerKind Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[workspace.lints.rust] warnings = "deny"and[workspace.lints.clippy] all = "deny"to rootCargo.toml[lints] workspace = trueFixes
uninit_vecwasm.rsset_lenafterwith_capacity— capacity already allocates; caller writes before readingmissing_const_for_thread_localwasm.rs,lib.rsconst { RefCell::new(...) }initializer syntaxmissing_safety_docwasm.rs# Safetysections to all fourpub unsafe extern "C"fnsclone_on_copywasm.rs,lib.rs.clone()onCopyCallerKindderivable_implstype_impls.rsCallerKindis typify-generated;Unknownis not the first variant so#[default]can't be added without patching codegenTest plan
cargo clippy --all-targets --all-features→ no warnings, no errors🤖 Generated with Claude Code