Add diff_mode property to DashboardTableColumn resource to specify primary keys in a table resource #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashboard inputs are now passed using InputValues struct, which also contains TimeRange Add TailpipeConnection Add DetectionTimeRange to DashboardExecutionTree - if provided, set BackendOpts Everything which was a connection string as a string now uses ConnectionStringProvider Add DateTimeRange Picker for Detection Benchmark
…primary keys in a table
pskrbasu
changed the title
kaidaguerre
requested changes
Nov 29, 2024
| diags = append(diags, &hcl.Diagnostic{ | ||
| Severity: hcl.DiagError, | ||
| Detail: err.Error(), | ||
| Subject: block.DefRange.Ptr(), |
Contributor
There was a problem hiding this comment.
use hclhelpers.BlockRange
|
|
||
| // Validate checks the validity of the column's properties and sets default values. | ||
| func (c *DashboardTableColumn) Validate() error { | ||
| // validate Display |
Contributor
There was a problem hiding this comment.
define map[string]struct{} of validDisplay and and diffmode properties
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stalled for 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.