Python 3 fix for PR: #172 from dato-code/added-groupby-aggregates #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gates PR turi-code#172 fails on Python 3 because of None comparisons. - In Python 2: None < 1 - In Python 3: None < 2 returns an error. The test case was changed to compare list([1,None]) where the order is interchangable to comparisons on set([1,None]).
ylow
pushed a commit
that referenced
this pull request
Feb 18, 2016
Python 3 fix for PR: #172 from dato-code/added-groupby-aggregates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #172 fails on Python 3 because of None comparisons.
The test case was changed to compare list([1,None]) where the order is
interchangable to comparisons on set([1,None]).