[pull] master from php:master #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests need to live in ext/opcache, or they will break the file cache job.
Observers add an extra tmp, breaking the expected output.
This test still fails on i386 Windows with "Allowed memory size of %d bytes exhausted" because the output buffer grows too big. My first intuition was to add a chunk_size to ob_start, but this won't work if the output buffer is flushed deep into the call stack, causing a premature or just a second stack limit error. So, reduce the stack size in an attempt to produce less output.
* PHP-8.4: [skip ci] Reduce zend.max_allowed_stack_size in gh20840.phpt
* PHP-8.5: [skip ci] Reduce zend.max_allowed_stack_size in gh20840.phpt
The computed number of properties using zend_hash_num_elements(zobj->properties) is incorrect when the object contains virtual properties. We don't have a trivial way to find the number of properties virtual properties that need to be added to this number, so just append with zend_hash_add_new() instead. Fixes GH-20479 Closes GH-20988
* PHP-8.4: Fix hooked object properties overflow
* PHP-8.5: Fix hooked object properties overflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )