Merged
Conversation
3 tasks
smn
force-pushed
the
smn/phase-4-parser-improvements
branch
from
f9c2c7c to
5f80dc2
Compare
smn
force-pushed
the
smn/phase-5-context-normalisation
branch
from
0d33c92 to
2987227
Compare
santiagocardo
previously approved these changes
Apr 17, 2026
Contributor
Author
|
Will look at merging this later. The earlier PRs don't seem to have merged into develop for some reason |
smn
force-pushed
the
smn/phase-5-context-normalisation
branch
from
2987227 to
1b8b8d2
Compare
4 tasks
Contributor
Author
|
Sorry @santiagocardo this now has PRs 2, 3, and 4 merged in because somehow I managed to screw up the PR chain. Apologies. You already reviewed & approved this earlier so hoping you can still follow along. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lowercase_keysandcoerce_stringsoptions toContext.new/2skip_context_evaluation?kept as backwards-compatible aliasDepends on #324
Details
Context options:
lowercase_keys: falsepreserves original key casing (atom keys still stringified).coerce_strings: falsepreserves all string values as-is. Default behavior (bothtrue) unchanged. Options pass throughbuild/2.Case-insensitive lookup:
Eval.case_insensitive_get/2tries exact match first (fast path), falls back to case-insensitive key scan. Enableslowercase_keys: falsewithout breaking expressions — the parser already lowercases variable names in the AST, so@firstnameresolves against a"FirstName"key.Engage audit: Engage already uses lowercase string keys in context maps. No engage changes needed — options are opt-in for consumers with case-sensitive external data.
Test plan
🤖 Generated with Claude Code