Merged
Conversation
- ifutil.py: Add retry loop (10s timeout) in set_dhcp() for non-blocking DHCP clients like dhcpcd. The previous code checked for an IP address immediately after ifup returned, but dhcpcd forks and assigns the address asynchronously (~3s delay). - ifutil.py: Add get_ipv6conf() to retrieve global-scope IPv6 address and prefix length via 'ip -6 addr show'. - confconsole.py: Display IPv6 address in both the main services screen and the networking configuration screen when available. Tested on Proxmox LXC unprivileged container (Moodle v19, Trixie) with dhcpcd as the sole DHCP client (dual-stack DHCPv4/DHCPv6).
_get_default_nic() only checked IPv4 via get_ipconf(), causing confconsole to report 'Networking is not yet configured' on IPv6-only hosts despite having a valid global address. Add get_ipv6conf() fallback in _validip(): if no valid IPv4 is found, check for a global-scope IPv6 address before declaring the interface unconfigured. This enables IPv6-first deployments to pass the network check without requiring an IPv4 address.
Pass IPv6 address as $ip6addr to services.txt template instead of appending it after substitution. Uses safe_substitute so appliances without $ip6addr in their services.txt are unaffected. Ref: turnkeylinux/tracker#1658
Member
Author
|
Let me know what you think @OnGle |
Member
marcos-mendez
left a comment
marcos-mendez
left a comment
There was a problem hiding this comment.
Sorry got a litttle messy my comment but here it is
Member
Author
|
Thanks @marcos-mendez 😁 Looking closer it's called 4 times...! First @ 334 in I've removed that last one and moved TBH I think now we're making ipv6 a "first class citizen" refactoring the whole layout would be nice. As an aside, @OnGle & I have often talked about possibly ditching dialog altogether. But all of that's for another day... |
Member
Author
|
FYI I've just packaged this and pushed it to the TKL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of @marcos-mendez's #101 PR - see that for full details of the IPv6 update.
This PR: