Skip to content

upgrade libsql-js: 0.4.1 -> 0.4.4#262

Merged
sivukhin merged 3 commits intomainfrom
upgrade-to-0.4.4
Sep 13, 2024
Merged

upgrade libsql-js: 0.4.1 -> 0.4.4#262
sivukhin merged 3 commits intomainfrom
upgrade-to-0.4.4

Conversation

@sivukhin
Copy link
Copy Markdown
Contributor

@sivukhin sivukhin commented Sep 13, 2024

We need latest version of libsql-js to have full vector support in embedded replicas

This PR also adds simple example with vector feature in embedded replica.

Comment thread package-lock.json
"detect-libc": "2.0.2"
},
"optionalDependencies": {
"@libsql/darwin-arm64": "0.4.1",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm....not sure why this huge diff is produced...
I just run npm install in the root of the project which automatically fix package-lock.json...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is due to the fix I made for having a cyclic dependency so this makes sense

@sivukhin sivukhin requested review from LucioFranco and penberg and removed request for penberg September 13, 2024 12:30
Comment thread package-lock.json
"detect-libc": "2.0.2"
},
"optionalDependencies": {
"@libsql/darwin-arm64": "0.4.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is due to the fix I made for having a cyclic dependency so this makes sense

@sivukhin sivukhin merged commit 10cd150 into main Sep 13, 2024
@penberg penberg deleted the upgrade-to-0.4.4 branch September 13, 2024 12:51
@@ -0,0 +1,51 @@
import { createClient } from "@libsql/client";
import reader from "readline-sync";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example suggests a deprecated lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants