Merged
Conversation
ea4fe4d to
8b67e1f
Compare
LucioFranco
reviewed
Jan 2, 2024
| Ok(ret) | ||
| } | ||
|
|
||
| fn exclusive_mode(&mut self, op: c_int) -> Result<()> { |
Contributor
There was a problem hiding this comment.
are we going to have issues with these not being forwarded to the inner wal impl?
Contributor
Author
There was a problem hiding this comment.
It's forwarded by default; notice how we are not implementing Wal but WrapWal now :) this is a convenient trait that helps compose WAL implementations. Upstream, I have stuff like:
let wal_manager = Sqlite3WalManager::default()
.wrap(TakeReaderWrapper(tmp.path().to_path_buf()))
.wrap(ReplicationIndexInjectorWrapper);so that it's super easy to only implement what you need for WAL implementation that wrap other WAL implementations
Comment on lines
+3
to
+5
| use std::collections::HashMap; | ||
| use std::path::Path; | ||
| use std::sync::Arc; |
LucioFranco
approved these changes
Jan 3, 2024
Contributor
|
I think you're still missing the instrument macro though I think we should add that. |
c2cfa45 to
1403601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the meta store backup and restore logic using a bottomless-enabled connection. I cleaned up the code a bit to to reuse WAL wrapper patterns by implementing WrapWal for
Option<T>and used that for
ReplicationWaland the meta store connection.Configuration for the meta store durability is passed at thanks to new cli arguments: