Only show 'search mailbox' in settingsView for browser #8851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrb-hub
force-pushed
the
8834-SearchIndexing-option-only-in-browser
branch
from
ffe9121 to
aade48b
Compare
4 tasks
wrdhub
reviewed
Apr 10, 2025
hrb-hub
force-pushed
the
8834-SearchIndexing-option-only-in-browser
branch
from
aade48b to
40008a7
Compare
charlag
approved these changes
Apr 14, 2025
Since there is not a separate db for searching when offline storage is available, having the "Search mailbox" option does not make sense, since search is always enabled. The option remains for web version. Close: #8834 Co-authored-by: hrb-hub <hrb-hub@users.noreply.github.com>
hrb-hub
force-pushed
the
8834-SearchIndexing-option-only-in-browser
branch
from
40008a7 to
dc72b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is not a separate db for searching when offline storage is available, having the "Search mailbox" option does not make sense, since search is always enabled.
The option remains for web version.
Close: #8834
Test notes
settings/emailview on desktop and mobile and search is always enabled