Swap to napi-rs, fix CI and build scripts, update libuiohook#3
Merged
Conversation
checkraisefold
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. Additionally, updates uiohook by a couple years (fixed an issue for cross compilation), removes a debug print from
windows.rs, and updates the README a bit.CI now works fine, napi-rs with proper threading in place of node-bindgen. CI builds successfully on Windows and Linux.
napi-rs should automate half the manual work we do, but I didn't want to modify the github action that much. We can work on fixing that down the line.
Tested on Vesktop with minor modifications to the current PR to remove the legacy
display_idargument, works great.