Merged
Conversation
pybind11 v3.0.1 reads `Python_EXECUTABLE` instead of `PYTHON_EXECUTABLE`. The old variable name was silently ignored so that CMake's FindPython picked up whatever Python was first in the system PATH instead of the one running the build. Fixes #34
fakufaku
approved these changes
Mar 22, 2026
Collaborator
fakufaku
left a comment
fakufaku
left a comment
There was a problem hiding this comment.
Nice find. Thanks for taking the time to fix this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pybind11 v3.0.1 reads
Python_EXECUTABLEinstead ofPYTHON_EXECUTABLE. The old variable name was silently ignored so that CMake's FindPython picked up whatever Python was first in the system PATH instead of the one running the build.See https://github.com/pybind/pybind11/blob/master/tools/pybind11Config.cmake.in#L81
Fixes #34