fix: allow dots in app names for Windows/macOS#1215
Open
yumingyuan2 wants to merge 1 commit into
Open
Conversation
yumingyuan2
commented
Jun 6, 2026
yumingyuan2
commented
- Add '.' to isValidName regex for non-Linux platforms
- Preserve dots in resolveLocalAppName normalization
- Update error message to reflect dots are allowed
- Fix .gitignore order so !dist/cli.js negation takes effect
- Add '.' to isValidName regex for non-Linux platforms - Preserve dots in resolveLocalAppName normalization - Update error message to reflect dots are allowed - Fix .gitignore order so !dist/cli.js negation takes effect Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
For most websites, this is a harmless fix, but for applications with official names containing ., it helps maintain naming consistency more effectively. |
Owner
|
@yumingyuan2 thanks for the PR. I kept the intended behavior and shipped it in V3.11.8 via df62f18: macOS and Windows app names now allow dots inside names, local file names preserve dots, Linux package names stay strict, and regression tests were added. I did not take the .gitignore change because dist/cli.js is already tracked while dist/ stays ignored. Maintainers should keep regenerating it with pnpm run cli:build and stage it explicitly when needed. This PR is now covered by the maintainer patch on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.