fix: reject blank numeric CLI values#1224
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dist/cli.jsso the published CLI bundle matches the source change.Problem
validateNumberInput()usedNumber(value)directly. In JavaScript,Number("")andNumber(" ")both evaluate to0, so blank input could be accepted as a valid numeric value for options using this shared validator, such as--min-widthand--min-height.Before / after
Before:
validateNumberInput("")returned0.validateNumberInput(" ")returned0.After:
InvalidArgumentError("Not a number.").1200and0keep working.Verification
corepack pnpm exec vitest run tests/unit/cli-options.test.ts→ 9 tests passed.corepack pnpm run cli:buildcompleted successfully and regenerateddist/cli.js.git diff --checkpasses.