Set up release-please#74
Conversation
Build matrix runs in parallel with release-please (restoring per-push CI). The release job consumes those attested artifacts and uploads them only when release-please cuts a release. Binary version is sourced from the main.go const (kept in sync by release-please) so release assets match the tag.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR integrates Google's ChangesRelease-Please Setup and Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Sets up automated releases for lfm-cli using release-please, moving release creation into the renamed Go workflow so that artifacts are built on pushes and attached when a release is cut.
Changes:
- Add
release-pleaseconfig + manifest to manage versions and releases. - Update the GitHub Actions workflow to run
release-please, build attested artifacts, and upload them to the created GitHub release. - Update README badge and align
main.goversion constant forrelease-pleasetracking.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
release-please-config.json |
Defines release-please configuration for a Go release and tracks main.go as an extra versioned file. |
.release-please-manifest.json |
Adds the release-please manifest to track the current version for the root package. |
.github/workflows/go.yml |
Introduces release-please job and updates release flow to upload build artifacts when a release is created. |
main.go |
Updates version constant and marks it for release-please management. |
README.md |
Updates the GitHub Actions status badge to the renamed workflow. |
Comments suppressed due to low confidence (1)
.github/workflows/go.yml:84
- The workflow extracts VERSION from main.go with sed, but if the pattern stops matching (e.g., const moved into a const block or reformatted), sed will still exit successfully and VERSION will be empty, producing incorrectly named artifacts (and potentially incorrect release asset names). Consider validating that VERSION is non-empty (and failing the step) before writing BINARY_NAME, or extracting the version in a less brittle way.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Automate releases with release-please as a job in the renamed
go.ymlworkflow (wasbuild.yml); build runs on every push and the release job uploads those attested artifacts when release-please cuts a release.Summary by CodeRabbit