Skip to content

feat: update Docker configuration to mount fonts and templates directories for runtime configuration#3

Merged
twangodev merged 1 commit intomainfrom
fix/docker-runtime
Oct 17, 2025
Merged

feat: update Docker configuration to mount fonts and templates directories for runtime configuration#3
twangodev merged 1 commit intomainfrom
fix/docker-runtime

Conversation

@twangodev
Copy link
Owner

@twangodev twangodev commented Oct 17, 2025

Summary by CodeRabbit

  • Chores
    • Reduced container image size by moving font assets and configuration to external runtime volume mounts instead of bundling them. Fonts, configuration files, and templates are now externally mounted, enabling customization without container rebuilds.

Copilot AI review requested due to automatic review settings October 17, 2025 19:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Docker configuration to enable runtime mounting of fonts and templates directories instead of copying them at build time. This change allows for dynamic configuration updates without requiring container rebuilds.

  • Removes static font and font configuration copying from the Dockerfile
  • Adds volume mounts in docker-compose.yml for fonts, font configuration, and templates directories
  • Enables runtime configuration changes by mounting directories as read-only volumes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docker-compose.yml Adds volume mounts for fonts, fonts.yaml, and templates directories
Dockerfile Removes static copying of fonts directory and fonts.yaml file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@twangodev twangodev enabled auto-merge (rebase) October 17, 2025 19:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

Walkthrough

The changes coordinate to reduce the Docker image size by removing fonts and fonts.yaml from the final image, while adding corresponding volume mounts in docker-compose.yml to provide these resources at runtime instead.

Changes

Cohort / File(s) Summary
Image asset removal
Dockerfile
Removes COPY instructions for fonts directory and fonts.yaml file from build stage to final image
Runtime volume mounts
docker-compose.yml
Adds three read-only volume mounts to ogis service: ./fonts/app/fonts, ./fonts.yaml/app/fonts.yaml, and ./templates/app/templates

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Fonts and templates hop outside the frame,
No longer baked within the Docker's name,
Volume mounts deliver them with grace,
A leaner image finds its perfect place!
ᐯ ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "feat: update Docker configuration to mount fonts and templates directories for runtime configuration" accurately describes the primary changes in the pull request. The title captures the core architectural shift: moving fonts and templates from build-time inclusion (removed from Dockerfile) to runtime mounting via docker-compose.yml volume mounts. The title is concise, specific, and clearly communicates the intent of the changes in a way that would help teammates quickly understand the purpose when scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/docker-runtime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@twangodev twangodev disabled auto-merge October 17, 2025 19:01
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 607a876 and 3c16c68.

📒 Files selected for processing (2)
  • Dockerfile (0 hunks)
  • docker-compose.yml (1 hunks)
💤 Files with no reviewable changes (1)
  • Dockerfile

@twangodev twangodev merged commit bd5a050 into main Oct 17, 2025
7 checks passed
@twangodev twangodev deleted the fix/docker-runtime branch October 17, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants